Add flag to suppress stream errors #6458
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cmb69 Does this look like a sensible thing to do? |
|
Probably, yes, but it is slightly confusing to also have |
|
@cmb69 Right. I believe that flag is primarily used when opening streams, in which case we don't yet have a stream on which a flag can be set, so we need to pass it in separately. |
|
Indeed, and that is even explained in docs/streams.md. So it makes sense to introduce the new flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mysqlnd currently sets error_reporting=0 to suppress errors while writing to streams. Unfortunately these errors are still visible to userland error handlers, which is a common source of confusion. See for example https://bugs.php.net/bug.php?id=80412.
This patch instead adds a stream flag to suppress read/write errors, which is set by mysqlnd and respected by the plain & socket streams.